abstractdog commented on code in PR #5838:
URL: https://github.com/apache/hive/pull/5838#discussion_r2207322097
##########
beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java:
##########
@@ -195,12 +202,11 @@ public File saveDir() {
@Override
- public int complete(String buf, int pos, List cand) {
+ public void complete(LineReader reader, ParsedLine line, List<Candidate>
candidates) {
Review Comment:
apparently, since Jline3 a Completer doesn't return a value, we cannot
preserve that behavior:
https://github.com/jline/jline3/blob/778edccd4c1d863c2d3a89b9fc387c38203c7009/reader/src/main/java/org/jline/reader/Completer.java#L61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
