deniskuzZ commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2209474822
##########
iceberg/iceberg-catalog/pom.xml:
##########
@@ -69,7 +69,6 @@
<dependency>
<groupId>org.apache.hive</groupId>
<artifactId>hive-exec</artifactId>
- <scope>test</scope>
Review Comment:
`iceberg-catalog` shouldn't have any dependency on runtime (hive-exec) !!
This is a temporary copy of `iceberg-hive-metastore`, a direct dependency of
`iceberg-spark-runtime`.
With the removal of `iceberg-hive-runtime` in Iceberg 1.8, Impala needs to
adopt the Hive Iceberg runtime jar.
https://github.com/apache/impala/blob/41b6652fbf612a44676fed1cd9bd0da45133a04d/fe/pom.xml#L437-L441
PS: Only resolve comments after reaching consensus!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
