zratkai commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2209547530
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##########
@@ -298,7 +295,8 @@ private static String getCatalogType(Configuration conf,
String catalogName) {
return catalogType;
}
} else {
- String catalogType = conf.get(CatalogUtil.ICEBERG_CATALOG_TYPE);
+ String catalogType = conf.get(InputFormatConfig.catalogPropertyConfigKey(
Review Comment:
Thanks for the feedback. Some of the comments seem very detailed or
explanatory. It might be more efficient to focus the review on issues like
logic, readability, or potential bugs. If anything’s unclear, feel free to try
running the code — that might help clarify things faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
