deniskuzZ commented on code in PR #5628: URL: https://github.com/apache/hive/pull/5628#discussion_r2209516964
########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java: ########## @@ -73,6 +71,8 @@ public final class Catalogs { public static final String SNAPSHOT_REF = "snapshot_ref"; private static final String NO_CATALOG_TYPE = "no catalog"; + private static final String REST_CATALOG_TYPE = "rest"; Review Comment: Iceberg already has constant for that: `CatalogUtil.ICEBERG_CATALOG_TYPE_REST` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org