zhangbutao commented on code in PR #6123:
URL: https://github.com/apache/hive/pull/6123#discussion_r2444528305
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g:
##########
@@ -1144,6 +1147,13 @@ catalogComment
-> ^(TOK_CATALOGCOMMENT $comment)
;
+catProperties
+@init { pushMsg("catproperties", state); }
+@after { popMsg(state); }
+ :
+ LPAREN dbPropertiesList RPAREN -> ^(TOK_CATALOGPROPERTIES
dbPropertiesList)
Review Comment:
> hm, an all of them use same `TOK_CATALOGPROPERTIES` token?
`TOK_CATALOGPROPERTIES` is only used for catalog.
But your comment made me realize that we can replace dcProperties,
dbProperties, and catProperties in ANTLR file with properties. Fixed in
https://github.com/apache/hive/pull/6123/commits/900a662d40f3e3e39a9a952cdac3216324a977c4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
