deniskuzZ commented on code in PR #6123:
URL: https://github.com/apache/hive/pull/6123#discussion_r2446020432
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g:
##########
@@ -181,8 +189,8 @@ alterDatabaseStatementSuffix
alterDatabaseSuffixProperties
@init { gParent.pushMsg("alter database properties statement", state); }
@after { gParent.popMsg(state); }
- : name=identifier KW_SET KW_DBPROPERTIES dbProperties
- -> ^(TOK_ALTERDATABASE_PROPERTIES $name dbProperties)
+ : name=identifier KW_SET KW_DBPROPERTIES properties
Review Comment:
should it be KW_DBPROPERTIES or we can reuse KW_PROPERTIES?
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g:
##########
@@ -697,8 +705,8 @@ alterDataConnectorStatementSuffix
alterDataConnectorSuffixProperties
@init { gParent.pushMsg("alter connector set properties statement", state); }
@after { gParent.popMsg(state); }
- : name=identifier KW_SET KW_DCPROPERTIES dcProperties
- -> ^(TOK_ALTERDATACONNECTOR_PROPERTIES $name dcProperties)
+ : name=identifier KW_SET KW_DCPROPERTIES properties
Review Comment:
same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
