zhangbutao commented on code in PR #6123:
URL: https://github.com/apache/hive/pull/6123#discussion_r2446502554
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g:
##########
@@ -161,6 +161,14 @@ alterCatalogStatementSuffix
@init { gParent.pushMsg("alter catalog statement", state); }
@after { gParent.popMsg(state); }
: alterCatalogSuffixSetLocation
+ | alterCatalogSuffixProperties
+ ;
+
+alterCatalogSuffixProperties
+@init { gParent.pushMsg("alter catalog properties statement", state); }
+@after { gParent.popMsg(state); }
+ : name=identifier KW_SET KW_PROPERTIES properties
Review Comment:
No, `KW_CATPROPERTIES`, `KW_DBPROPERTIES`, and `KW_DBPROPERTIES `represent
different keywords - `catproperties`, `dbproperties`, and `dcproperties
`respectively.
For example: alter database db1 set `dbproperties`('key'='value'). But we
can not replace `dbproperties` with `properties` as this will change the
existing syntax.
However, for catalog, I prefer using just `KW_PROPERTIES` (`properties`)
since the keyword `catproperties `is too dialect-specific.
https://github.com/apache/hive/blob/75e40b7537c91a70ccaa31c397d21823c7528eeb/parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexerParent.g#L189-L190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
