zhangbutao commented on code in PR #6123:
URL: https://github.com/apache/hive/pull/6123#discussion_r2453743595
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g:
##########
@@ -161,6 +161,14 @@ alterCatalogStatementSuffix
@init { gParent.pushMsg("alter catalog statement", state); }
@after { gParent.popMsg(state); }
: alterCatalogSuffixSetLocation
+ | alterCatalogSuffixProperties
+ ;
+
+alterCatalogSuffixProperties
+@init { gParent.pushMsg("alter catalog properties statement", state); }
+@after { gParent.popMsg(state); }
+ : name=identifier KW_SET KW_PROPERTIES properties
Review Comment:
This is not good. If we use `KW_CATPROPERTIES ` but want to use `properties`
for catalog, we need to add the keyword into HiveLexerParent.g:
`KW_CATPROPERTIES: 'PROPERTIES' `
This means `KW_CATPROPERTIES` is used to Identify the
properties`(PROPERTIES).
However, in HiveLexerParent.g, the conventional naming style is like
`KW_DBPROPERTIES: 'DBPROPERTIES';`, where `KW_DBPROPERTIES` is used to
recognize `dbproperties` (DBPROPERTIES). I don't want to break this default
naming convention.
So I believe `KW_PROPERTIES: 'PROPERTIES'` is more appropriate for catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
