Aggarwal-Raghav commented on PR #6207: URL: https://github.com/apache/hive/pull/6207#issuecomment-3566227939
> We can amend some points, [following SonarQube](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6207&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true). > > I wonder if we can remove some more. Probably, the answer is no. > > ``` > % git grep 'Class.forName' | grep Driver > beeline/src/java/org/apache/hive/beeline/BeeLine.java: Driver driver = (Driver) Class.forName(clazzName, true, > beeline/src/java/org/apache/hive/beeline/Commands.java: Driver driver = (Driver) Class.forName(name).newInstance(); > beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java: (Driver) Class.forName(clazzName, true, Thread.currentThread().getContextClassLoader()) > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcStorageHandler.java: classesToLoad.add(Class.forName("com.mysql.jdbc.Driver")); > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcStorageHandler.java: classesToLoad.add(Class.forName("org.postgresql.Driver")); > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcStorageHandler.java: classesToLoad.add(Class.forName("oracle.jdbc.OracleDriver")); > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcStorageHandler.java: classesToLoad.add(Class.forName("com.microsoft.sqlserver.jdbc.SQLServerDriver")); > jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcStorageHandler.java: classesToLoad.add(Class.forName("com.ibm.db2.jcc.DB2Driver")); > ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java: Class<?> cls = Class.forName(name); > ql/src/test/org/apache/hadoop/hive/ql/TestDriverFactory.java: Class<?> cls = Class.forName(name); > ``` > > If we can reduce the usage, is it possible to remove `CONNECTION_DRIVER` in HiveConf and MetastoreConf? Have removed reflection code changes from `BeeLine.java`, `Commands.java`, `DatabaseConnection.java`. Please review it. Changes in `JdbcStorageHandler.java`, `DriverFactory.java` are not specific to DriverManager and are outside the scope of PR IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
