Aggarwal-Raghav commented on PR #6207: URL: https://github.com/apache/hive/pull/6207#issuecomment-3576863354
> I'm feeling now `MetastoreConf.ConfVars.CONNECTION_DRIVER` is used only for logging purposes, and keeping it might cause a confusion; what if `CONNECTION_DRIVER` is for Postgres but the connection URL is for MySQL? I wonder if we can remote it and `HiveConf.ConfVars.METASTORE_CONNECTION_DRIVER` in this pull request, or if it's impossible, or if we should separatre a pull request @okumin , thanks for the thorough review. What you mentioned is correct but I'm not sure, it will be that easy to remove `CONNECTION_DRIVER` config from `HiveConf` HiveConf => Used, despite being Deprecated https://github.com/apache/hive/blob/526bd87e9103375f0ddb8064dcfd8c31342b4c08/jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/DatabaseAccessorFactory.java#L73 MetaStoreConf=> Used in QTests (possible + achievable but requires cleanup from lot of places which is outside scope of this PR) https://github.com/apache/hive/blob/594e5701a49f308b235d4483d760089dc68d14fb/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/PostgresTPCDS.java#L66 I'm hoping we can target this in separate JIRA. I have filed JIRA [HIVE-29289](https://issues.apache.org/jira/browse/HIVE-29289) sometime back . Maybe as part of that cleanup as a follow-up I can try this. Also, the recent sonarcloud was there before my changes as well and I was hoping it can be ignored if no changes in this PR are required. Running CI again doesn't seems ok to me. Let me know your thoughts on this part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
