Aggarwal-Raghav commented on code in PR #6207:
URL: https://github.com/apache/hive/pull/6207#discussion_r2564556772
##########
hplsql/src/main/java/org/apache/hive/hplsql/Conn.java:
##########
@@ -146,15 +146,11 @@ synchronized Connection getConnection(String connName)
throws Exception {
* @throws Exception
*/
Connection openConnection(String connStr) throws Exception {
- String driver = "org.apache.hadoop.hive.jdbc.HiveDriver";
StringBuilder url = new StringBuilder();
String usr = "";
String pwd = "";
if (connStr != null) {
String[] c = connStr.split(";");
- if (c.length >= 1) {
- driver = c[0];
Review Comment:
`connStr` is coming a method argument and I'm not changing the logic of how
the connStr is passed by caller i.e.
connStr = `driver_class_name;jdbc_url;user;password` will remain same. So,
there is no need to update `connStr.split(";")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
