ramitg254 commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2708423739
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/formatter/TextDescTableFormatter.java:
##########
@@ -171,7 +171,12 @@ private void addPartitionData(DataOutputStream out,
HiveConf conf, String column
boolean isFormatted, boolean isOutputPadded) throws IOException {
String partitionData = "";
if (columnPath == null) {
- List<FieldSchema> partitionColumns = table.isPartitioned() ?
table.getPartCols() : null;
+ List<FieldSchema> partitionColumns = null;
+ if (table.isPartitioned()) {
+ partitionColumns = table.hasNonNativePartitionSupport() ?
Review Comment:
yes actually my first approach was to do this only but there were issues
regarding when statistics were computed after insertion resulting in index out
of bound exception as that is dependent `getPartCols` but this is the only one
known to me but there can be other scenarios where it is getting used and can
cause issues so avoiding this for now.
and will tackle this code duplication once we have updated implementation of
`getPartCols `with a follow up ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
