ramitg254 commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2708569252
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -567,6 +567,17 @@ public static List<String> getPartitionNames(Table table,
Map<String, String> pa
}
}
+ public static boolean hasPartition(Table icebergTable,
+ Map<String, String> partitionSpec) throws
MetaException {
+ try {
+ List<String> partNames = getPartitionNames(icebergTable, partitionSpec,
false);
+ return !partNames.isEmpty() &&
+ Warehouse.makePartName(partitionSpec,
false).equals(partNames.getFirst());
Review Comment:
so either if we are moving it then hms table should be used as parameter
if you thing iceberg table as parameter for method to be used then moving it
won't be good IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
