ramitg254 commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2708562942
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -567,6 +567,17 @@ public static List<String> getPartitionNames(Table table,
Map<String, String> pa
}
}
+ public static boolean hasPartition(Table icebergTable,
+ Map<String, String> partitionSpec) throws
MetaException {
+ try {
+ List<String> partNames = getPartitionNames(icebergTable, partitionSpec,
false);
+ return !partNames.isEmpty() &&
+ Warehouse.makePartName(partitionSpec,
false).equals(partNames.getFirst());
Review Comment:
yes I am doing this only, but just a minor doubt on my end if we move
`getPartition` to `IcebergTableUtil` it will be fine if we use hms table as
parameter as you mentioned but it should have iceberg table as parameter
instead of hms table similar to other methods in the file and if we are using
iceberg table as parameter then it will not offload much from storage handler
as creating dummy partition requires hms table as param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
