VenuReddy2103 commented on code in PR #6416:
URL: https://github.com/apache/hive/pull/6416#discussion_r3086565588
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/HouseKeepingTasks.java:
##########
@@ -69,6 +69,12 @@ public List<MetastoreTaskThread> getRemoteOnlyTasks() throws
Exception {
Collection<String> taskNames =
MetastoreConf.getStringCollection(configuration,
MetastoreConf.ConfVars.TASK_THREADS_REMOTE_ONLY);
+ if (!MetastoreConf.getBoolVar(configuration,
MetastoreConf.ConfVars.METASTORE_SUPPORT_ACID)) {
+
taskNames.removeAll(ImmutableSet.of(MetastoreConf.ACID_OPEN_TXNS_COUNTER_SERVICE_CLASS,
+ MetastoreConf.ACID_HOUSEKEEPER_SERVICE_CLASS,
Review Comment:
Have tried to handle at `LeaderElection.LeadershipStateListener` level most
of the cases like `CompactorTasks`, `HouseKeepingTasks` instead of leaf level
(`MetastoreTaskThread`). Thought we can avoid all those instance creations,
`setConf()`/`init() `which internally gets `TxnUtils.getTxnStore(conf)` and
internally `setConf()` of txnHandler etc if we do at `LeadershipStateListener`
level.
But in case of `CompactionHouseKeeperService`, a part of its
functionality((i.e., `txnHandler::purgeCompactionHistory` alone) is required
when `MetastoreConf.ConfVars.METASTORE_SUPPORT_ACID` is disabled. So have
handled at leaf level.
What is your opinion ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
