dengzhhu653 commented on code in PR #6416:
URL: https://github.com/apache/hive/pull/6416#discussion_r3192729518
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDefaultTransformer.java:
##########
@@ -614,6 +614,26 @@ private static final Path getDefaultPath(IHMSHandler
hmsHandler, Database db, St
}
+ private void transformToExternalIfAcidNotSupported(Table table) throws
MetaException {
+ Map<String, String> params = table.getParameters();
+ boolean isSupportAcid = MetastoreConf.getBoolVar(hmsHandler.getConf(),
+ ConfVars.METASTORE_SUPPORT_ACID);
+ if (!isSupportAcid) {
+ if (Boolean.parseBoolean(params.get(TABLE_IS_TRANSACTIONAL))) {
+ throw new MetaException("ACID tables are not permitted when the "
+ + ConfVars.METASTORE_SUPPORT_ACID.getHiveName() + " property is
set to false");
+ }
+ if (TableType.MANAGED_TABLE.name().equals(table.getTableType())) {
+ table.setTableType(TableType.EXTERNAL_TABLE.toString());
Review Comment:
this means all tables' data cannot be removed upon dropping the table, until
we drop these table files directly, is it supposed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
