VenuReddy2103 commented on code in PR #6416:
URL: https://github.com/apache/hive/pull/6416#discussion_r3123091899
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/HouseKeepingTasks.java:
##########
@@ -69,6 +69,12 @@ public List<MetastoreTaskThread> getRemoteOnlyTasks() throws
Exception {
Collection<String> taskNames =
MetastoreConf.getStringCollection(configuration,
MetastoreConf.ConfVars.TASK_THREADS_REMOTE_ONLY);
+ if (!MetastoreConf.getBoolVar(configuration,
MetastoreConf.ConfVars.METASTORE_SUPPORT_ACID)) {
+
taskNames.removeAll(ImmutableSet.of(MetastoreConf.ACID_OPEN_TXNS_COUNTER_SERVICE_CLASS,
+ MetastoreConf.ACID_HOUSEKEEPER_SERVICE_CLASS,
+ MetastoreConf.ACID_TXN_CLEANER_SERVICE_CLASS,
+ MetastoreConf.MATERIALZIATIONS_REBUILD_LOCK_CLEANER_TASK_CLASS));
Review Comment:
When acid function is disabled, we support materialized views only in
iceberg format(i.e, cannot have mv in HIVE ACID format). MV in iceberg format
do not use `MATERIALIZATION_REBUILD_LOCKS`. Have refactored this code for
another comment to disable the task when `runFrequency()` returns 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
