ramitg254 commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3141625954
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/AcidExportSemanticAnalyzer.java:
##########
@@ -175,7 +175,8 @@ private void analyzeAcidExport(ASTNode ast, Table
exportTable, ASTNode tokRefOrN
//now generate insert statement
//insert into newTableName select * from ts <where partition spec>
StringBuilder rewrittenQueryStr = generateExportQuery(
- newTable.getPartCols(), tokRefOrNameExportTable, (ASTNode)
tokRefOrNameExportTable.parent, newTableName);
+ newTable.getEffectivePartCols(),
Review Comment:
did this beacuse of this
https://github.com/apache/hive/pull/6413#issuecomment-4318406188 if you think
it can break things then I will switch it back to old one
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/rewrite/sql/NativeAcidMultiInsertSqlGenerator.java:
##########
@@ -45,9 +45,9 @@ public void appendAcidSelectColumns(Operation operation) {
@Override
public List<String> getDeleteValues(Operation operation) {
- List<String> deleteValues = new ArrayList<>(1 +
targetTable.getPartCols().size());
+ List<String> deleteValues = new ArrayList<>(1 +
targetTable.getEffectivePartCols().size());
Review Comment:
https://github.com/apache/hive/pull/6413#discussion_r3141625954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
