deniskuzZ commented on PR #6413: URL: https://github.com/apache/hive/pull/6413#issuecomment-4319684816
> I was planning to but updating getCols() will alone cause test failures for all q files whichever has describe command for iceberg tables and also query plans will itself get affected as stats logic current take this getCols() into account and there are around 90+ occurences of it in code so it will lead to breakage as well so I thought it will be better if we take care of it as a separate change I guess that was the main intent — to integrate Iceberg partition handling into the existing code with minimal workarounds/code duplication. Maybe I’m missing something, but, unfortunately, I don’t see much value in the current state of PR, sorry. It doesn’t seem to enable any missing partition optimizations (there are no q-test changes), including the one mentioned above in HIVE-29525, and instead appears to be more of a partial refactor. Let’s see what Krisztian thinks about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
