ramitg254 commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3141639292
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -109,6 +112,7 @@ public class Table implements Serializable {
/**
* These fields are all cached fields. The information comes from tTable.
*/
+ private List<FieldSchema> cachedPartCols;
Review Comment:
1. yes it can be renamed to partitionCols as it was added because for
iceberg table getStorageHandler.getPartitionKeys() calls convertToIceberg so
too much calls to metastore was made for a given particular running query and
too many calls were leading to sometime timed out exception and some other
exception due to some outdated conf.
to avoid that it was added so it is not really a cahe
2. I think we shouldn't setPartitionKeys for ttable for non native tables as
partition evolution and other stuff are supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
