1fanwang commented on code in PR #6454:
URL: https://github.com/apache/hive/pull/6454#discussion_r3150188622
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java:
##########
@@ -83,12 +83,6 @@ private Catalog createCatalog() {
if (configWarehouse != null) {
properties.put("warehouse", configWarehouse);
Review Comment:
Done — pushed ce92efc and f3f3a56 between them. The local-warehouse property
now goes through `CatalogProperties.WAREHOUSE_LOCATION` and the
external-warehouse path stays on `HiveCatalog.EXTERNAL_WAREHOUSE_LOCATION`
(since that constant is what HiveCatalog itself reads on the receiving end).
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java:
##########
Review Comment:
Switched in f3f3a56 — `properties.put(CatalogProperties.URI, configUri)`.
Comment above the block updated to reference `CatalogProperties.URI` so the
behavior reads consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
