rubenada commented on code in PR #6523: URL: https://github.com/apache/hive/pull/6523#discussion_r3783361089
########## iceberg/iceberg-handler/src/test/results/positive/llap/iceberg_bucket_map_join_1.q.out: ########## Review Comment: You're right. The plan changes actually "broked" the test coverage that this file was supposed to verify. I managed to bring back the original plans, by slightly altering (changing the condition column) the impacted queries (the ones with the DISTINCT in the sub-select), so now the plan shapes are maintained, even with the metadata estimate modifications coming from the Calcite upgrade. ########## iceberg/iceberg-handler/src/test/results/positive/llap/iceberg_bucket_map_join_1.q.out: ########## Review Comment: You're right. The plan changes actually "broke" the test coverage that this file was supposed to verify. I managed to bring back the original plans, by slightly altering (changing the condition column) the impacted queries (the ones with the DISTINCT in the sub-select), so now the plan shapes are maintained, even with the metadata estimate modifications coming from the Calcite upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
