rubenada commented on code in PR #6523:
URL: https://github.com/apache/hive/pull/6523#discussion_r3785110894
##########
ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out:
##########
@@ -2301,10 +2307,10 @@ STAGE PLANS:
Map Operator Tree:
TableScan
alias: srcpart
- filterExpr: UDFToDouble(hr) is not null (type: boolean)
+ filterExpr: (UDFToDouble(hr) * 2.0D) is not null (type:
boolean)
Review Comment:
This is because `hr` is a string, so `UDFToDouble(hr)` is not a lossless
casts, and now the simplification does not apply because the expression
contains this "unsafe cast".
I think the actual root cause for this was:
[[CALCITE-5769]](https://issues.apache.org/jira/browse/CALCITE-5769) Optimizing
'CAST(e AS t) IS NOT NULL' to 'e IS NOT NULL' (only when "safe"); I'll update
the PR description to include this ticket too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
