rubenada commented on code in PR #6523:
URL: https://github.com/apache/hive/pull/6523#discussion_r3785196131
##########
ql/src/test/results/clientpositive/llap/explainuser_1.q.out:
##########
@@ -6562,7 +6562,7 @@ Stage-0
<-Select Operator [SEL_5] (rows=500 width=12)
Output:["_col0","_col1"]
Filter Operator [FIL_19] (rows=500 width=87)
- predicate:UDFToDouble(key) is not null
+ predicate:(UDFToDouble(key) + 1.0D) is not null
Review Comment:
Same pattern as other comment: `key` seems to be a string, so CAST to double
is not lossless, so RexSimplify no longer applies simplification in the
expression.
##########
ql/src/test/results/clientpositive/llap/explainuser_1.q.out:
##########
@@ -6562,7 +6562,7 @@ Stage-0
<-Select Operator [SEL_5] (rows=500 width=12)
Output:["_col0","_col1"]
Filter Operator [FIL_19] (rows=500 width=87)
- predicate:UDFToDouble(key) is not null
+ predicate:(UDFToDouble(key) + 1.0D) is not null
Review Comment:
Same pattern as other comments: `key` seems to be a string, so CAST to
double is not lossless, so RexSimplify no longer applies simplification in the
expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
