rubenada commented on code in PR #6523:
URL: https://github.com/apache/hive/pull/6523#discussion_r3785418130


##########
ql/src/test/results/clientpositive/llap/input8.q.out:
##########
@@ -36,14 +36,14 @@ STAGE PLANS:
             Map Operator Tree:
                 TableScan
                   alias: src1
-                  Statistics: Num rows: 25 Data size: 191 Basic stats: 
COMPLETE Column stats: COMPLETE
+                  Statistics: Num rows: 25 Data size: 2150 Basic stats: 
COMPLETE Column stats: COMPLETE
                   Select Operator
-                    expressions: null (type: string), null (type: int), null 
(type: double)
+                    expressions: null (type: string), 
UDFToInteger((UDFToDouble(key) - null)) (type: int), null (type: double)

Review Comment:
   This all comes back to the same "RexSimplify not simplifying non-lossless 
casts" any more.
   
   > The CAST in Hive does not throw an error ...
   
   If that's the case for Hive, shouldn't Hive plans use "SAFE_CAST" instead of 
"CAST" ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to