aw-was-here commented on a change in pull request #212:
URL: https://github.com/apache/yetus/pull/212#discussion_r564980273
##########
File path: shelldocs/src/main/python/shelldocs.py
##########
@@ -261,12 +261,12 @@ def lint(self):
getfuncs = {
"audience": self.getaudience,
"stability": self.getstability,
- "replaceable": self.replacetext,
+ "replaceable": self.getreplace,
}
validvalues = {
"audience": ("Public", "Private"),
"stability": ("Stable", "Evolving"),
- "replaceable": ("yes", "no"),
+ "replaceable": ("Yes", "No"),
Review comment:
The point of YETUS-1089 was to better enforce the ruleset and provide
valid output. 'yes' or 'no' are the values that are considered valid. A value
of 'Yes' or 'No' would be considered invalid and they should throw an error.
Checking the validity of the rendered output rather than the parsed value
doesn't do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
