aajisaka commented on a change in pull request #212:
URL: https://github.com/apache/yetus/pull/212#discussion_r564990737
##########
File path: shelldocs/src/main/python/shelldocs.py
##########
@@ -261,12 +261,12 @@ def lint(self):
getfuncs = {
"audience": self.getaudience,
"stability": self.getstability,
- "replaceable": self.replacetext,
+ "replaceable": self.getreplace,
}
validvalues = {
"audience": ("Public", "Private"),
"stability": ("Stable", "Evolving"),
- "replaceable": ("yes", "no"),
+ "replaceable": ("Yes", "No"),
Review comment:
https://github.com/apache/yetus/blob/227c762a0154c3465923d3b59ebdb3063bbd95ca/shelldocs/src/main/python/shelldocs.py#L283
You said the validity check should be case-sensitive, so I thought
`value.lower()` should be `value` in the error message. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
