aajisaka commented on a change in pull request #212:
URL: https://github.com/apache/yetus/pull/212#discussion_r564992223
##########
File path: shelldocs/src/main/python/shelldocs.py
##########
@@ -261,12 +261,12 @@ def lint(self):
getfuncs = {
"audience": self.getaudience,
"stability": self.getstability,
- "replaceable": self.replacetext,
+ "replaceable": self.getreplace,
}
validvalues = {
"audience": ("Public", "Private"),
"stability": ("Stable", "Evolving"),
- "replaceable": ("yes", "no"),
+ "replaceable": ("Yes", "No"),
Review comment:
> I thought value.lower() should be value in the error message.
Umm. It is not good for other attrs because the validity check of the attrs
looks case-insensitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
