@eht16 commented on this pull request.


> @@ -16,9 +16,11 @@ AM_PROG_CC_C_O
 AC_DISABLE_STATIC
 AC_PROG_LIBTOOL
 
-dnl i18n
-IT_PROG_INTLTOOL([0.35.0])
-GP_I18N
+dnl i18n, inline so autoreconf can detect gettext usage
+AM_GNU_GETTEXT_VERSION([0.23.1])

It seems we need to define `AM_GNU_GETTEXT_REQUIRE_VERSION`.

>From my tests, it doesn't make a difference if we define it instead of or 
>additionally to `AM_GNU_GETTEXT_VERSION`, Windows build succeeds once it is 
>set.

Yet, I still have no clue why, what's the difference to Geany and what exactly 
these two options really do :(.

@b4n @techee do you have any clue or do we want to use it this way? I would 
cleanup the commits then.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1434#discussion_r2105801339
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1434/review/2866276...@github.com>

Reply via email to