@eht16 commented on this pull request.
> mkdir -p build/cache -intltoolize -c -f -autoreconf -vfi + +(cd $srcdir; autoreconf --install --verbose) > Why is `--force` (`-f`) dropped here? Without it I'd have to cleanup some > auto-copied files manually before I can use this: > > ``` > $ NOCONFIGURE=1 ./autogen.sh > autoreconf: export WARNINGS= > autoreconf: Entering directory '.' > autoreconf: running: autopoint > autopoint: File build/cache/nls.m4 has been locally modified. > autopoint: File po/Makefile.in.in has been locally modified. > autopoint: *** Some files have been locally modified. Not overwriting them > because --force has not been specified. For your convenience, you find the > local modifications in the file '/tmp/artiVqY7/gtX8ppkg/autopoint.diff'. > autopoint: *** Stop. > autoreconf: error: autopoint failed with exit status: 1 > ``` > With it, it happily replaces the files it wants, which non are tracked and we > rely on autoreconf to copy over. So, I'm wondering if there's a reason _not_ > to force-overwrite them, or if it just makes our lives that much harder if we > change anything that affects it. I see it's the same in Geany now, but I'm > still puzzled. I had this as well a few times but not always. This is probably part of the puzzle what's different here from Geany. Thomas removed the `--force` in https://github.com/geany/geany/pull/3092 but I guess you already have seen this. I don't mind much, if it works better with `--force` and it affects only files not checked in in GIT, then it's probably fine to use. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1434#discussion_r2106147076 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1434/review/2866787...@github.com>
