@b4n commented on this pull request.
> mkdir -p build/cache -intltoolize -c -f -autoreconf -vfi + +(cd $srcdir; autoreconf --install --verbose) Why is `--force` (`-f`) dropped here? Without it I'd have to cleanup some auto-copied files manually before I can use this: ```console $ NOCONFIGURE=1 ./autogen.sh autoreconf: export WARNINGS= autoreconf: Entering directory '.' autoreconf: running: autopoint autopoint: File build/cache/nls.m4 has been locally modified. autopoint: File po/Makefile.in.in has been locally modified. autopoint: *** Some files have been locally modified. Not overwriting them because --force has not been specified. For your convenience, you find the local modifications in the file '/tmp/artiVqY7/gtX8ppkg/autopoint.diff'. autopoint: *** Stop. autoreconf: error: autopoint failed with exit status: 1 ``` With it, it happily replaces the files it wants, which non are tracked and we rely on autoreconf to copy over. So, I'm wondering if there's a reason *not* to force-overwrite them, or if it just makes our lives that much harder if we change anything that affects it. I see it's the same in Geany now, but I'm still puzzled. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1434#pullrequestreview-2866421668 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1434/review/[email protected]>
