@b4n commented on this pull request.
> @@ -593,8 +593,8 @@ static void print_external(GeanyDocument *doc)
return;
}
- cmdline = g_strdup(printing_prefs.external_print_cmd);
- utils_str_replace_all(&cmdline, "%f", doc->file_name);
+ /* replace d, e, f and p placeholders in cmdline */
+ cmdline = utils_replace_placeholder(doc,
printing_prefs.external_print_cmd, "defp");
This *changes* the meaning of `%f` in a build command, and will probably result
in print failures for people using this already, as the new `%f` is the file's
*basename* (i.e. without path), and the current directory is likely *not* gonna
be the file's one. And AFAICT, this command was not usable without `%f`, so it
effectively affects anybody currently using the feature.
Is it really not a concern? Should we somehow migrate previous values? (which
would mean using `%d/%f`) Or change working directory of the command to `%d`?
(but that can have odd side effects)
I'm not particularly into external print commands, but I'm not at ease with
incompatible changes that will break user's setups.
@eht16 opinion?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4250#pullrequestreview-2884589898
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/4250/review/2884589...@github.com>
