@b4n commented on this pull request.
> @@ -593,8 +593,8 @@ static void print_external(GeanyDocument *doc)
return;
}
- cmdline = g_strdup(printing_prefs.external_print_cmd);
- utils_str_replace_all(&cmdline, "%f", doc->file_name);
+ /* replace d, e, f and p placeholders in cmdline */
+ cmdline = utils_replace_placeholder(doc,
printing_prefs.external_print_cmd, "defp");
OK. And I guess as @Pynckels put effort on this as well they see benefit from
it -- I don't particularly see much myself as I feel `%f` was easier to use
than `%d/%f`, and the other placeholders are not useful enough to a print
command to really be useful as all but `%p` (and %`l`, but it was not added in
this PR) could already be derived from what `%f` was before if need be.
Anyway, now we have it why not, but we need to get this sorted out for 2.1 :)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4250#discussion_r2133750638
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/4250/review/[email protected]>
