@eht16 commented on this pull request.


> @@ -593,8 +593,8 @@ static void print_external(GeanyDocument *doc)
                return;
        }
 
-       cmdline = g_strdup(printing_prefs.external_print_cmd);
-       utils_str_replace_all(&cmdline, "%f", doc->file_name);
+       /* replace d, e, f and p placeholders in cmdline */
+       cmdline = utils_replace_placeholder(doc, 
printing_prefs.external_print_cmd, "defp");

I'd been also fine with reverting this PR but since you already put so much 
efforts in getting in right, I think we can continue with #4319.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4250#discussion_r2133729004
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/4250/review/[email protected]>

Reply via email to