mingmwang commented on code in PR #2168:
URL: https://github.com/apache/arrow-datafusion/pull/2168#discussion_r844531090
##########
ballista/rust/core/src/serde/mod.rs:
##########
@@ -508,15 +508,10 @@ mod tests {
&self,
children: Vec<Arc<dyn ExecutionPlan>>,
) -> datafusion::error::Result<Arc<dyn ExecutionPlan>> {
- match children.len() {
- 1 => Ok(Arc::new(TopKExec {
- input: children[0].clone(),
- k: self.k,
- })),
- _ => Err(DataFusionError::Internal(
- "TopKExec wrong number of children".to_string(),
- )),
- }
+ Ok(Arc::new(TopKExec {
Review Comment:
I'm not sure in Rust whether I can declare a method in the Trait to
`protected` so that it can only be visible in this module and in the Trait
implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
