mingmwang commented on PR #2168:
URL:
https://github.com/apache/arrow-datafusion/pull/2168#issuecomment-1091026228
> ExecutionPlan
> I think this looks great @mingmwang -- thank you very much.
>
> Another thing we might want to consider doing would be to change the
signature of `ExecutionPlan` trait to _require_ an `Arc` to call
`with_new_children`, like so:
>
> ```rust
> fn with_new_children(
> self: Arc<Self>,
> children: Vec<Arc<dyn ExecutionPlan>>,
> ) -> Result<Arc<dyn ExecutionPlan>> {
> // put with_new_children_if_necessary implementation here
> ...
> }
> ```
>
> That would ensure that we could always apply the
`with_new_children_if_necessary` logic
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
