vibhatha commented on code in PR #13468:
URL: https://github.com/apache/arrow/pull/13468#discussion_r912300942
##########
cpp/src/arrow/engine/substrait/relation_internal.cc:
##########
@@ -106,17 +106,16 @@ Result<compute::Declaration> FromProto(const
substrait::Rel& rel,
path = item.uri_path_glob();
}
- if (item.format() ==
- substrait::ReadRel::LocalFiles::FileOrFiles::FILE_FORMAT_PARQUET) {
- format = std::make_shared<dataset::ParquetFileFormat>();
- } else if (util::string_view{path}.ends_with(".arrow")) {
- format = std::make_shared<dataset::IpcFileFormat>();
- } else if (util::string_view{path}.ends_with(".feather")) {
- format = std::make_shared<dataset::IpcFileFormat>();
- } else {
- return Status::NotImplemented(
- "substrait::ReadRel::LocalFiles::FileOrFiles::format "
- "other than FILE_FORMAT_PARQUET");
+ switch (item.file_format_case()) {
+ case substrait::ReadRel_LocalFiles_FileOrFiles::kParquet:
+ format = std::make_shared<dataset::ParquetFileFormat>();
+ break;
+ case substrait::ReadRel_LocalFiles_FileOrFiles::kArrow:
+ format = std::make_shared<dataset::IpcFileFormat>();
+ break;
+ default:
+ return Status::NotImplemented(
+ "unknown
substrait::ReadRel::LocalFiles::FileOrFiles::file_format");
Review Comment:
What about `feather` format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
