vibhatha commented on code in PR #13468:
URL: https://github.com/apache/arrow/pull/13468#discussion_r912301625
##########
cpp/src/arrow/engine/substrait/type_internal.cc:
##########
@@ -196,10 +196,11 @@ Result<std::pair<std::shared_ptr<DataType>, bool>>
FromProto(
field("value", std::move(value_nullable.first),
value_nullable.second));
}
- case ::substrait::Type::kUserDefinedTypeReference: {
- uint32_t anchor = type.user_defined_type_reference();
+ case ::substrait::Type::kUserDefined: {
+ const auto& user_defined = type.user_defined();
+ uint32_t anchor = user_defined.type_reference();
ARROW_ASSIGN_OR_RAISE(auto type_record, ext_set.DecodeType(anchor));
- return std::make_pair(std::move(type_record.type), true);
+ return std::make_pair(std::move(type_record.type),
IsNullable(user_defined));
Review Comment:
@jvanstraten
Before it was set to true always. Not sure why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
