jvanstraten commented on code in PR #13468:
URL: https://github.com/apache/arrow/pull/13468#discussion_r912346149
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -185,7 +185,8 @@ TEST(Substrait, SupportedExtensionTypes) {
ASSERT_OK_AND_ASSIGN(
auto buf,
internal::SubstraitFromJSON(
- "Type", "{\"user_defined_type_reference\": " +
std::to_string(anchor) + "}"));
+ "Type", "{\"user_defined\": { \"type_reference\": " +
std::to_string(anchor) +
+ ", \"nullability\": \"NULLABILITY_NULLABLE\" } }"));
Review Comment:
No, Substrait itself didn't consider user-defined types to conceptually have
nullability, for no particular reason I can think of. See
https://github.com/substrait-io/substrait/pull/217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
