lidavidm commented on code in PR #13959:
URL: https://github.com/apache/arrow/pull/13959#discussion_r954854668
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -350,23 +351,25 @@ class ARROW_DS_EXPORT FileWriter {
/// \brief Options for writing a dataset.
struct ARROW_DS_EXPORT FileSystemDatasetWriteOptions {
/// Options for individual fragment writing.
- std::shared_ptr<FileWriteOptions> file_write_options;
+ std::shared_ptr<FileWriteOptions> file_write_options =
+ CsvFileFormat().DefaultWriteOptions();
Review Comment:
default to ArrowFileFormat, since CSV is optional? (Though I guess, maybe
you can't build datasets without CSV.)
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -386,7 +389,7 @@ struct ARROW_DS_EXPORT FileSystemDatasetWriteOptions {
/// and only write the row groups to the disk when sufficient rows have
accumulated.
/// The final row group size may be less than this value and other options
such as
/// `max_open_files` or `max_rows_per_file` lead to smaller row group sizes.
- uint64_t min_rows_per_group = 0;
+ uint64_t min_rows_per_group = 10;
Review Comment:
Why 10 and not something larger? Alternatively, why set this by default at
all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
