AlvinJ15 commented on code in PR #13959:
URL: https://github.com/apache/arrow/pull/13959#discussion_r955669970
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -386,7 +389,7 @@ struct ARROW_DS_EXPORT FileSystemDatasetWriteOptions {
/// and only write the row groups to the disk when sufficient rows have
accumulated.
/// The final row group size may be less than this value and other options
such as
/// `max_open_files` or `max_rows_per_file` lead to smaller row group sizes.
- uint64_t min_rows_per_group = 0;
+ uint64_t min_rows_per_group = 10;
Review Comment:
According with the ticket
https://issues.apache.org/jira/browse/ARROW-15409?filter=-1, it suggest to set
a value higher than 0, I use the 10 as I saw in some tests, what value would be
apropiate for this?
@westonpace the `max_rows_per_group` is already `1 << 20` maybe I need to
put a lower value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
