fatemehp commented on code in PR #14142:
URL: https://github.com/apache/arrow/pull/14142#discussion_r974511972
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -1328,6 +1329,156 @@ class TypedRecordReader : public
ColumnReaderImplBase<DType>,
return records_read;
}
+
+ // Skip records that we have in our buffer. This function is only for
+ // non-repeated fields.
+ int64_t SkipRecordsInBufferNonRepeated(int64_t num_records) {
+ ARROW_DCHECK(this->max_rep_level_ == 0);
+ ARROW_DCHECK(this->has_values_to_process());
Review Comment:
I removed the check and added a return statement.
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -1268,7 +1269,7 @@ class TypedRecordReader : public
ColumnReaderImplBase<DType>,
records_read += ReadRecordData(num_records);
}
- int64_t level_batch_size = std::max(kMinLevelBatchSize, num_records);
+ int64_t level_batch_size = std::max<int>(kMinLevelBatchSize, num_records);
Review Comment:
done
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -1005,7 +1005,7 @@ int64_t
TypedColumnReaderImpl<DType>::ReadBatchWithDictionary(
// Read dictionary indices.
*indices_read = ReadDictionaryIndices(indices_to_read, indices);
- int64_t total_indices = std::max(num_def_levels, *indices_read);
+ int64_t total_indices = std::max<int>(num_def_levels, *indices_read);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
