AlenkaF commented on code in PR #14350: URL: https://github.com/apache/arrow/pull/14350#discussion_r997869121
########## docs/source/developers/python.rst: ########## @@ -518,13 +518,11 @@ We set a number of environment variables: - the path of the installation directory of the Arrow C++ libraries as ``ARROW_HOME`` -- add the path of installed DLL libraries to ``PATH`` - and the CMake generator to be used as ``PYARROW_CMAKE_GENERATOR`` .. code-block:: - $ set ARROW_HOME=%cd%\arrow-dist - $ set PATH=%ARROW_HOME%\bin;%PATH% + $ set ARROW_HOME=%CONDA_PREFIX% Review Comment: I think `ARROW_HOME` is still needed: https://github.com/apache/arrow/blob/21dbf4ac09583651899232c9a80b3f5d6580a588/python/pyarrow/src/CMakeLists.txt#L43-L44 Maybe it somehow works in conda env but it didn't work for me (MacOS with `brew` and `pip`): ``` (pyarrow-dev-9) (base) alenkafrim@Alenkas-MacBook-Pro arrow % arrow cpp ~/repos/arrow/cpp/build ~/repos/arrow [585/585] Linking CXX executable debug/arrow-dataset-scanner-test [1/2] Install the project... -- Install configuration: "DEBUG" CMake Error at cmake_install.cmake:41 (file): file cannot create directory: /lib/cmake/Arrow. Maybe need administrative privileges. FAILED: CMakeFiles/install.util cd /Users/alenkafrim/repos/arrow/cpp/build && /opt/homebrew/Cellar/cmake/3.24.2/bin/cmake -P cmake_install.cmake ninja: build stopped: subcommand failed. ~/repos/arrow ``` after exporting `ARROW_HOME` the installation was successful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
