jorisvandenbossche commented on code in PR #14350: URL: https://github.com/apache/arrow/pull/14350#discussion_r998084057
########## docs/source/developers/python.rst: ########## @@ -518,13 +518,11 @@ We set a number of environment variables: - the path of the installation directory of the Arrow C++ libraries as ``ARROW_HOME`` -- add the path of installed DLL libraries to ``PATH`` - and the CMake generator to be used as ``PYARROW_CMAKE_GENERATOR`` .. code-block:: - $ set ARROW_HOME=%cd%\arrow-dist - $ set PATH=%ARROW_HOME%\bin;%PATH% + $ set ARROW_HOME=%CONDA_PREFIX% Review Comment: `ARROW_HOME` is also "necessary" if you follow the developers docs because we use this env variable to set some other things, like `CMAKE_INSTALL_PREFIX`. But you can of course pass a path to that as well, without using ARROW_HOME for this. And on unix, I suppose having ARROW_HOME defined so that cmake adds it to `CMAKE_PREFIX_PATH` might not be needed when using cmake from conda (then the conda prefix might already be included in ``CMAKE_SYSTEM_PREFIX_PATH`` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
