jackwener commented on code in PR #4711:
URL: https://github.com/apache/arrow-datafusion/pull/4711#discussion_r1056753570
##########
datafusion/sql/src/planner.rs:
##########
@@ -820,45 +818,20 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
// normalize all columns in expression
let using_columns = expr.to_columns()?;
- let normalized_expr = normalize_col_with_schemas(
+ let filter = normalize_col_with_schemas(
expr,
&[left.schema(), right.schema()],
&[using_columns],
)?;
- // expression that didn't match equi-join pattern
- let mut filter = vec![];
-
- // extract join keys
Review Comment:
Happy to see them are removed from planner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
