ygf11 commented on PR #4711: URL: https://github.com/apache/arrow-datafusion/pull/4711#issuecomment-1364480944
@jackwener Thanks for review. I think it is ok. > But now this rule is previous. Can this rule ignore B.key = C.key? or we need reorder rule? No, this rule will ignore `B.key = C.key`. Because this rule will treat eq expression as equijoin only when each side of `eq` belong to one input. For `B.key = C.key`, `B.key` and `C.key` are both belong to `B join C`, no key is belong to `A` so this predicate will be added to the filter. I add a new test `join_with_multiple_table_and_eq_filter` to cover it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
