mustafasrepo commented on code in PR #7129:
URL: https://github.com/apache/arrow-datafusion/pull/7129#discussion_r1277722494
##########
datafusion/physical-expr/src/aggregate/array_agg_ordered.rs:
##########
@@ -228,11 +231,13 @@ impl Accumulator for OrderSensitiveArrayAggAccumulator {
.iter()
.map(|sort_expr| sort_expr.options)
.collect::<Vec<_>>();
- self.values = merge_ordered_arrays(
+ let (new_values, new_orderings) = merge_ordered_arrays(
Review Comment:
Since we no longer rely on outside mechanism for merging, During merging we
need to merge orderings (additional to values).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
