mustafasrepo commented on code in PR #7129:
URL: https://github.com/apache/arrow-datafusion/pull/7129#discussion_r1278576304
##########
datafusion/core/src/physical_plan/aggregates/order/mod.rs:
##########
@@ -52,7 +52,6 @@ impl GroupOrdering {
} = ordering;
Ok(match mode {
- GroupByOrderMode::None => GroupOrdering::None,
Review Comment:
I should have stressed it, this change, doesn't affect code path for
GroupOrderingNone. I recognized that we already store aggregation as option as
in
[link](https://github.com/apache/arrow-datafusion/blob/01d7dbaf392b4a217e1a27c96bbcd1126b763828/datafusion/core/src/physical_plan/aggregates/mod.rs#L269).
When this mode is `Option::None`, it is equivalent to
`GroupByOrderMode::None`. So I thought, there is no need to keep track of
`AggregationMode::None` separately. As can be seen in
[link](https://github.com/apache/arrow-datafusion/blob/01d7dbaf392b4a217e1a27c96bbcd1126b763828/datafusion/core/src/physical_plan/aggregates/row_hash.rs#L239).
When option is `None`, `GroupOrdering::None ` is used. If this is misleading,
I can retract this change. It is not important, for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
