niyue commented on code in PR #38116:
URL: https://github.com/apache/arrow/pull/38116#discussion_r1364794972
##########
cpp/src/gandiva/llvm_generator_test.cc:
##########
@@ -115,4 +117,14 @@ TEST_F(TestLLVMGenerator, TestAdd) {
EXPECT_EQ(out_bitmap, 0ULL);
}
+TEST_F(TestLLVMGenerator, VerifyExtendedPCFunctions) {
+ ARROW_EXPECT_OK(LoadTestLLVMIR());
Review Comment:
Yes, currently we don't provide an API to unregister/unload a function, and
the IR store is a global state which will affect other tests as well, but it
should not cause any trouble for other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
