kou commented on code in PR #38116:
URL: https://github.com/apache/arrow/pull/38116#discussion_r1364871331
##########
cpp/src/gandiva/engine.cc:
##########
@@ -248,11 +250,11 @@ Status Engine::LoadPreCompiledIR() {
Status::CodeGenError("Could not load module from IR: ",
buffer_or_error.getError().message()));
- std::unique_ptr<llvm::MemoryBuffer> buffer =
std::move(buffer_or_error.get());
+ auto buffer = std::move(buffer_or_error.get());
/// Parse the IR module.
- llvm::Expected<std::unique_ptr<llvm::Module>> module_or_error =
- llvm::getOwningLazyBitcodeModule(std::move(buffer), *context());
+ auto module_or_error = llvm::getOwningLazyBitcodeModule(std::move(buffer),
*context());
Review Comment:
I general, I like `auto` than explicit type declaration. Because long
explicit type declaration causes long line/expression. It decreases readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
